[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502

MananTank · 2024-11-23T01:26:42Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the MarkdownRenderer component and its associated styles, enhancing the rendering of Markdown content with improved class names and structure, while also adding Storybook stories for testing various configurations.

Detailed summary

Replaced px, pt, and pb props with className in MarkdownRenderer.
Updated styles in inline-code component.
Added Storybook setup for MarkdownRenderer with multiple stories.
Introduced a comprehensive Markdown example for testing.
Refactored MarkdownRenderer to use ReactMarkdown instead of chakra for rendering.
Enhanced heading, link, code, paragraph, list, and table components with Tailwind CSS classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-23T01:26:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	🔄 Building (Inspect)			Nov 23, 2024 2:04am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Nov 23, 2024 2:04am
thirdweb_playground	⬜️ Skipped (Inspect)	Nov 23, 2024 2:04am
wallet-ui	⬜️ Skipped (Inspect)	Nov 23, 2024 2:04am

changeset-bot · 2024-11-23T01:26:46Z

⚠️ No Changeset found

Latest commit: a8bca1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-11-23T01:26:48Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

MananTank · 2024-11-23T01:27:00Z

[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2024-11-23T01:27:30Z

apps/dashboard/src/components/contract-components/published-contract/markdown-renderer.tsx

+}> = ({
+  markdownText,
+  className,
+  disableCodeHighlight: disableCodeHightlight,


There appears to be a typo in the prop destructuring - disableCodeHightlight is missing an 'l'. The alias should be disableCodeHighlight: disableCodeHighlight.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

codecov · 2024-11-23T01:29:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.09%. Comparing base (eb72886) to head (adda60c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5502   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files        1074     1074           
  Lines       55632    55632           
  Branches     3907     3907           
=======================================
  Hits        24533    24533           
  Misses      30416    30416           
  Partials      683      683

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from eb72886
packages	`38.85% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

github-actions · 2024-11-23T01:31:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.97 KB (0%)	900 ms (0%)	252 ms (+34.65% 🔺)	1.2 s
thirdweb (cjs)	105.01 KB (0%)	2.2 s (0%)	583 ms (+52.39% 🔺)	2.7 s
thirdweb (minimal + tree-shaking)	5.6 KB (0%)	113 ms (0%)	69 ms (+508.79% 🔺)	181 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	23 ms (+506.41% 🔺)	33 ms
thirdweb/react (minimal + tree-shaking)	18.38 KB (0%)	368 ms (0%)	182 ms (+214.05% 🔺)	550 ms

graphite-app · 2024-11-23T01:49:18Z

Merge activity

Nov 22, 8:49 PM EST: A user added this pull request to the Graphite merge queue.
Nov 22, 9:00 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www', 'check_linear_in_pr_body').
Nov 22, 9:05 PM EST: A user added this pull request to the Graphite merge queue.
Nov 22, 9:05 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the `MarkdownRenderer` component by updating its styling and structure, as well as adding comprehensive Storybook stories for better documentation and testing. ### Detailed summary - Replaced padding props with a `className` in `MarkdownRenderer`. - Updated styles for `inline-code` component. - Added Storybook stories for `MarkdownRenderer`, including examples and parameters for desktop and mobile views. - Improved the structure of the `MarkdownRenderer` component, including class-based styling and code highlighting features. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui November 23, 2024 01:26 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 23, 2024 01:26 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 23, 2024 01:26 Inactive

MananTank changed the title ~~[Dashboard] Migrate MarkdownRenderer to tailwind~~ [Dashboard] Migrate MarkdownRenderer to shadcn+tailwind Nov 23, 2024

MananTank marked this pull request as ready for review November 23, 2024 01:26

MananTank requested review from jnsdls and joaquim-verges as code owners November 23, 2024 01:27

graphite-app bot reviewed Nov 23, 2024

View reviewed changes

github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 23, 2024

jnsdls approved these changes Nov 23, 2024

View reviewed changes

MananTank force-pushed the 11-23-_dashboard_migrate_markdownrenderer_to_tailwind branch from 72b4a5e to a8bca1b Compare November 23, 2024 01:32

vercel bot temporarily deployed to Preview – wallet-ui November 23, 2024 01:32 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 23, 2024 01:32 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 23, 2024 01:32 Inactive

vercel bot deployed to Preview – thirdweb-www November 23, 2024 01:48 View deployment

MananTank force-pushed the 11-23-_dashboard_migrate_markdownrenderer_to_tailwind branch from a8bca1b to adda60c Compare November 23, 2024 01:50

vercel bot temporarily deployed to Preview – docs-v2 November 23, 2024 01:50 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 23, 2024 01:50 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 23, 2024 01:50 Inactive

vercel bot deployed to Preview – thirdweb-www November 23, 2024 01:59 View deployment

graphite-app bot merged commit adda60c into main Nov 23, 2024
31 of 32 checks passed

graphite-app bot deleted the 11-23-_dashboard_migrate_markdownrenderer_to_tailwind branch November 23, 2024 02:05

vercel bot temporarily deployed to Production – thirdweb_playground November 23, 2024 02:05 Inactive

vercel bot temporarily deployed to Production – wallet-ui November 23, 2024 02:05 Inactive

vercel bot temporarily deployed to Production – docs-v2 November 23, 2024 02:05 Inactive

vercel bot deployed to Production – thirdweb-www November 23, 2024 02:15 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502

[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502

Uh oh!

MananTank commented Nov 23, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Nov 23, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 23, 2024

Uh oh!

MananTank commented Nov 23, 2024

Uh oh!

graphite-app bot Nov 23, 2024

Uh oh!

MananTank Nov 23, 2024

Uh oh!

codecov bot commented Nov 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 23, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502

[Dashboard] Migrate MarkdownRenderer to shadcn+tailwind #5502

Uh oh!

Conversation

MananTank commented Nov 23, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Nov 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

MananTank commented Nov 23, 2024

Uh oh!

graphite-app bot Nov 23, 2024

Choose a reason for hiding this comment

Uh oh!

MananTank Nov 23, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Nov 23, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 23, 2024 •

edited

Loading

changeset-bot bot commented Nov 23, 2024 •

edited

Loading

codecov bot commented Nov 23, 2024 •

edited

Loading

github-actions bot commented Nov 23, 2024 •

edited

Loading

graphite-app bot commented Nov 23, 2024 •

edited

Loading